On Fri, 7 Mar 2025 05:19:54 GMT, Tejesh R <t...@openjdk.org> wrote: >> Jeremy Wood has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8351110: code cleanup >> >> This is in response to: >> https://github.com/openjdk/jdk/pull/23920#discussion_r1984465597 >> https://github.com/openjdk/jdk/pull/23920#discussion_r1984466151 >> https://github.com/openjdk/jdk/pull/23920#discussion_r1984466228 >> https://github.com/openjdk/jdk/pull/23920#discussion_r1984466870 >> >> This also updates the test summary, removes an unused method, and fixes a >> trivial compiler warning. > > test/jdk/javax/imageio/plugins/jpeg/WriteJPEGThumbnailTest line 2: > >> 1: /* >> 2: * Copyright (c) 20025, Oracle and/or its affiliates. All rights reserved. > > Suggestion: > > * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
Thanks, this is fixed. > test/jdk/javax/imageio/plugins/jpeg/WriteJPEGThumbnailTest line 38: > >> 36: import javax.imageio.stream.ImageInputStream; >> 37: import javax.imageio.stream.ImageOutputStream; >> 38: import java.awt.*; > > Please expand the wildcard imports. This is updated > test/jdk/javax/imageio/plugins/jpeg/WriteJPEGThumbnailTest line 41: > >> 39: import java.awt.geom.AffineTransform; >> 40: import java.awt.image.BufferedImage; >> 41: import java.io.*; > > Please expand the wildcard imports. This is updated > test/jdk/javax/imageio/plugins/jpeg/WriteJPEGThumbnailTest line 155: > >> 153: return null; >> 154: } >> 155: } > > Empty line at last is missing. This is updated ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23920#discussion_r1984532278 PR Review Comment: https://git.openjdk.org/jdk/pull/23920#discussion_r1984532353 PR Review Comment: https://git.openjdk.org/jdk/pull/23920#discussion_r1984532757 PR Review Comment: https://git.openjdk.org/jdk/pull/23920#discussion_r1984532444
