On Thu, 6 Mar 2025 20:11:20 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
> That is not a bad choice; this is how it should be implemented. Most, if not > all, of those code paths are security-related. You can consult with the > authors and reviewers of those patches to clarify why it was implemented that > way. Let's say i disagree here - and i talked with some of the authors and they did not sway my opinion.\ > But that new soundbank instrument is just a MIDI file rendered using the > default soundbank. Do we really need to render it? Wouldn't it be possible to > simply store the MIDI events and the soundbank and use them when the user > selects the instrument? No because rendering of the soundbank would take time - probably seconds - and that will throw reproduction of the second MIDI file off the track. I just remind that the MIDI we are rendering can come from any source - including the connected hardware like MIDI keyboard - and adding random delays before playing a note - even if it's one quarter or one eighth of a second will definitely be audible. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23814#discussion_r1986203616
