On Mon, 3 Mar 2025 12:11:30 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:

>> VoiceOver is unable to announce the correct value for spinner. For JSpinner 
>> with maximum value of more than 10, VO announce 10 as 1, 20 as 2 and so on. 
>> Probable reason is the "ACCESSIBLE_TEXT_PROPERTY" fired by accessible 
>> JTextComponent that leads to wrong range value invoked for accessibility API 
>> by VO.
>> Workaround fix is to ensure "ACCESSIBLE_TEXT_PROPOERTY" is not fired in case 
>> of JSpinner with numeric values.
>> 
>> Since the fix is in Java Component, verified fix with JAWS on windows. I 
>> don't see any side effects in announcement.
>> Manual test case is added to verify the fix.
>> 
>> CI pipeline testing is ok for the proposed fix.
>
> Abhishek Kumar has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix pushed to mac os specific class

LGTM. With the updated fix, VO announces percentage values consistently.

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23841#pullrequestreview-2672472354

Reply via email to