On Fri, 7 Mar 2025 12:38:08 GMT, Karm Michal Babacek <d...@openjdk.org> wrote:
>> Removed objectweb.asm for bytecode manipulation and uses JEP 484 classfile
>> API.
>>
>> Test passes on Linux amd64 so far:
>>
>> TIME=`date +%s`;
>> mkdir -p test.${TIME}/jdk/JTwork test.${TIME}/jdk/JTreport;
>> jtreg -a -ignore:quiet -w:test.${TIME}/jdk/JTwork
>> -r:test.${TIME}/jdk/JTreport
>> -jdk:/home/karm/workspaceRH/jdk/build/linux-x86_64-server-release/images/graal-builder-jdk/
>> /home/karm/workspaceRH/jdk/test/jdk/java/awt/Headless/
>>
>> Test results: passed: 15
>
> Karm Michal Babacek has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fixed @library /test -> @library /test/lib
The initial year in the copyright should be preserved; and a second one is to
be added if there's no second year, or the second year needs to be bumped to
the current year.
Other than that, it looks good.
test/jdk/java/awt/Headless/HeadlessMalfunctionAgent.java line 2:
> 1: /*
> 2: * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
Suggestion:
* Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights reserved.
The first year should be preserved; when there are two years, the last one gets
updated.
test/jdk/java/awt/Headless/HeadlessMalfunctionTest.java line 2:
> 1: /*
> 2: * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
Suggestion:
* Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights reserved.
-------------
Changes requested by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23852#pullrequestreview-2674244861
PR Review Comment: https://git.openjdk.org/jdk/pull/23852#discussion_r1989130920
PR Review Comment: https://git.openjdk.org/jdk/pull/23852#discussion_r1989164490
