On Wed, 12 Mar 2025 17:56:56 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java line 121:
>>
>>> 119: if (mainFrame != null) {
>>> 120: mainFrame.dispose();
>>> 121: mainFrame = null;
>>
>> Assigning `mainFrame = null` is not required since we are disposing the
>> frame at this point.
>
>> Assigning `mainFrame = null` is not required since we are disposing the
>> frame at this point.
>
> It's required here, because the loop is repeated, and setting `mainFrame` to
> `null` prevents access to a disposed frame… likely from disposing of the
> frame again.
Missed seeing the finally block is within the LaF loop. Looks fine then.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23964#discussion_r1992038099
