On Mon, 3 Mar 2025 05:57:33 GMT, Phil Race <p...@openjdk.org> wrote:

> The font tests that fail use non-finite or NaN float values.
> In such cases, no visible rendering is expected and the NaNTransform test 
> does pass with empty shapes, but we can filter out these invalid floats 
> before they get to native.
> The macOS class that handles the font strike can check for these and replace 
> them.
> Since you can't observe a difference unless you can get ubsan to work (not 
> easy) and that is a build option, so not something we can use in testing, 
> there' s no regression test update here.

Looks good.

-------------

Marked as reviewed by kizune (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23855#pullrequestreview-2700128396

Reply via email to