On Thu, 20 Mar 2025 05:32:22 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> src/java.desktop/share/classes/javax/swing/JTable.java line 2198: >> >>> 2196: if (getColumnSelectionAllowed()) { >>> 2197: selectColumns(columnCount); >>> 2198: } >> >> Can we simplify the code from line 2188 - 2198, since the intension is to >> selectRows/Columns if its available. >> ` >> if (rowCount > 0 ) { >> >> if (getRowSelectionAllowed()) { >> >> selectRows(rowCount); >> >> } >> >> } else if (columnCount > 0 ) { >> >> if (getColumnSelectionAllowed()) { >> >> selectColumns(columnCount); >> >> }` > > No that might change the existing behavior and JCK expectation for row>0 and > column>0 if we introduce the check.. > SO, I will like to keep it as it is.. > > You can raise a followon bug if you would like it to be worked on later.. Sure, raising a follow up bug makes sense. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24025#discussion_r2004901773