On Thu, 20 Mar 2025 22:04:19 GMT, Alexander Zvegintsev <azveg...@openjdk.org>
wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove AIX special handling from endian.h
>
> src/java.desktop/unix/native/libawt_xawt/awt/screencast_pipewire.c line 1104:
>
>> 1102: Java_sun_awt_screencast_ScreencastHelper_closeSession(JNIEnv *env,
>> jclass cls) {
>> 1103: }
>> 1104:
>
> Suggestion:
>
>
>
> This doesn't seem necessary since this method should only be called if
> `loadPipewire` returns true.
To me it sounds like defensive programming to include an implementation of all
native methods, so the JVM will not crash if it mistakenly is called. Do you
see a problem with that?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24009#discussion_r2006540766
