On Wed, 26 Mar 2025 08:00:05 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:

>> Are you thinking of specific test cases that are not covered here? Could you 
>> share, please? Or just about code refactoring?
>
> I wonder if we can return non-public or static methods from non-exported 
> interface? In other words are the checks 
> `!Modifier.isAbstract(method.getModifiers()) && !method.isBridge()` are good 
> enough?

There is the static method is the test scenario 1.

OK, I'd add the following methods to `interface A4`:

        public static int getStaticValue() {
            return 0;
        }
        private int getPrivateValue() {
            return 0;
        }

Is this the case you're thinking of?

Redarding properties, I think the implementation is OK. The only question in 
this case is should `getMethodDescriptors()` contain the static method (`public 
static int DefaultMethodBeanPropertyTest$A4.getStaticValue()`) or not?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23443#discussion_r2013608180

Reply via email to