On Fri, 4 Apr 2025 20:30:50 GMT, Phil Race <p...@openjdk.org> wrote:

> Open source a few tests related to Swing menus.

LGTM other than minor inline comments.

test/jdk/javax/swing/JPopupMenu/bug4187004.java line 98:

> 96:     }
> 97: 
> 98: 

Extra newlines can be removed.

test/jdk/javax/swing/JPopupMenu/bug4530303.java line 29:

> 27:  * @build PassFailJFrame
> 28:  * @summary Tests JPopupMenu.pack()
> 29:  * @key headful

`@key headful` redundant for manual tests

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24457#pullrequestreview-2744094693
PR Review Comment: https://git.openjdk.org/jdk/pull/24457#discussion_r2029428892
PR Review Comment: https://git.openjdk.org/jdk/pull/24457#discussion_r2029428455

Reply via email to