On Wed, 19 Mar 2025 07:33:36 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> I didn't mean that, I meant the other way. This would still modify the class 
>> variable right? And why do you want to use local variable ? Since you are 
>> getting selectionIndex, I don't think local variable would be helpful here.
>
> THis is the way it was done previously where also the action was done on 
> local var..please see previous code....the selectionIndex was obtained from 
> selectionModel class var..
> 
>> And why do you want to use local variable ? I don't think local variable 
>> would be helpful here.
> 
> I disagree..Using class variable directly might cause synchronization issue 
> which is mitigated by using local var..

I meant w.r.t modifications applied to class and local reference. If both are 
pointing to same variable you can minimise passing it as parameter in methods 
selectColumns/Rows. Just a suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24025#discussion_r2002776307

Reply via email to