On Fri, 4 Apr 2025 22:50:28 GMT, Phil Race <p...@openjdk.org> wrote:
> Open source two Swing JTabbedPane tests.
> One is problem listed for macOS because of the way Aqua displays tabs on the
> left + right.
test/jdk/javax/swing/JTabbedPane/bug4499556.java line 142:
> 140: button.addActionListener(new ActionListener() {
> 141: public void actionPerformed(ActionEvent e) {
> 142: if(pane.getTabCount() == 4) {
Suggestion:
if (pane.getTabCount() == 4) {
test/jdk/javax/swing/JTabbedPane/bug4499556.java line 231:
> 229: testPanel.add(comp);
> 230: JButton closeButton = new CloseButton();
> 231: closeButton.setPreferredSize(new Dimension(10,10));
Suggestion:
closeButton.setPreferredSize(new Dimension(10, 10));
test/jdk/javax/swing/JTabbedPane/bug4499556.java line 234:
> 232: testPanel.add(closeButton);
> 233: testPanel.setOpaque(false);
> 234: pane.insertTab("Test", null,new JLabel(""), "", 1);
Suggestion:
pane.insertTab("Test", null, new JLabel(""), "", 1);
test/jdk/javax/swing/JTabbedPane/bug6259533.java line 78:
> 76: pane.setTabComponentAt(1, label);
> 77: frame.add(pane);
> 78: frame.setSize(400,200);
Suggestion:
frame.setSize(400, 200);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24461#discussion_r2029913880
PR Review Comment: https://git.openjdk.org/jdk/pull/24461#discussion_r2029913906
PR Review Comment: https://git.openjdk.org/jdk/pull/24461#discussion_r2029913921
PR Review Comment: https://git.openjdk.org/jdk/pull/24461#discussion_r2029913953
