On Tue, 8 Apr 2025 13:37:17 GMT, Mikhail Yankelevich <myankelev...@openjdk.org> 
wrote:

>> Hi Reviewers,
>> 
>> I have updated the test and made it semi-automatic (need to click "Print") . 
>> Test will initiate a print and result will be generated automatic. 
>> 
>> Please review and let me know your suggestions.
>
> test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 112:
> 
>> 110:             // API 1: null & empty drawString(String, int, int);
>> 111:             try {
>> 112:                 g2d.drawString(nullStr, 20, 40);
> 
> Isn't it always null? Don't you think it is a bit misleading when reading the 
> test? 
> 
> Also applies to the lines 123, 134, 149

Yes it is, this test intended to  evaluate how `drawString` handle _null_ and 
_emptyStr_

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24501#discussion_r2034397289

Reply via email to