On Wed, 9 Apr 2025 21:26:16 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
> I'd probably return the resulting profile to run test on, it will make data > flow explicit. However, it'd be more verbose… to pass the test profile. My initial thought was same - return the profile, but chose to keep it as static var to reduce the number of arguments prepareTestProfile() & testProfile() and it makes the test code cleaner. > Could you write a comment that prepareTestProfile stores the profile to test > in testProfile? It could be a javadoc for the testProfile field. Updated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r2036204841
