On Tue, 8 Apr 2025 17:07:48 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix
>
> test/jdk/javax/swing/JInternalFrame/bug4190516.java line 60:
>
>> 58: fr.getContentPane().add(jdp);
>> 59:
>> 60: JInternalFrame jif = new JInternalFrame("Title", true, true,
>> true, true);
>
> Suggestion:
>
> JInternalFrame jif = new JInternalFrame("Title", true, true, true,
> true);
fixed
> test/jdk/javax/swing/JInternalFrame/bug4242045.java line 54:
>
>> 52: "Iconifiable", "Maximizable", "Closable" under different
>> LookAndFeels.
>> 53: If they appears and disappears correctly then test passes. If any
>> 54: button not appear or disappear as expected or appear with
>> incorrect
>
> Suggestion:
>
> button does not appear or disappear as expected or appear with
> incorrect
ok
> test/jdk/javax/swing/JTextField/bug4232716.java line 55:
>
>> 53: e = new JEditorPane("text/html", html);
>> 54: e.setEditable(false);
>> 55: frame.getContentPane().add(e);
>
> Suggestion:
>
> frame.add(e);
ok
> test/jdk/javax/swing/JTextField/bug5027332.java line 51:
>
>> 49: The caret should be placed slightly off text field borders,
>> 50: so that it can be easily distinguished from the border.
>> 51: Test fails if the caret touches the border.""";
>
> Just a thought: Would it be good to extend this test to all platforms
> (getSystemLookAndFeelClassName()) since it verifies if caret does not merge
> with the text field border?
Yes made it for SystemLookAndFeel
> test/jdk/javax/swing/JTextField/bug5027332.java line 70:
>
>> 68:
>> 69: private static JFrame createTestUI() {
>> 70:
>
> Extra line can be removed
ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24474#discussion_r2036529266
PR Review Comment: https://git.openjdk.org/jdk/pull/24474#discussion_r2036529375
PR Review Comment: https://git.openjdk.org/jdk/pull/24474#discussion_r2036529456
PR Review Comment: https://git.openjdk.org/jdk/pull/24474#discussion_r2036529830
PR Review Comment: https://git.openjdk.org/jdk/pull/24474#discussion_r2036529544
