On Sun, 6 Apr 2025 06:08:36 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:

> Clean up and open source four tests, two manual and two automatic tests now.

test/jdk/java/awt/Graphics/LineLocationTest.java line 98:

> 96: 
> 97: class DrawScreen extends Canvas {
> 98:     public Dimension getPreferredSize() {

Can add `@Override` for overridden methods here and in other tests too

test/jdk/java/awt/Graphics/TallText.java line 28:

> 26:  * @bug 4844952
> 27:  * @summary test large text draws properly to the screen
> 28:  * @key headful

`headful` tag not needed

test/jdk/java/awt/Graphics/TallText.java line 54:

> 52: 
> 53:     public void paint(Graphics g) {
> 54:         Font font = new Font("dialog", Font.PLAIN, 99);

Suggestion:

        Font font = new Font(Font.DIALOG, Font.PLAIN, 99);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24472#discussion_r2041979466
PR Review Comment: https://git.openjdk.org/jdk/pull/24472#discussion_r2041983193
PR Review Comment: https://git.openjdk.org/jdk/pull/24472#discussion_r2041984017

Reply via email to