On Fri, 11 Apr 2025 18:05:15 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Update to setPreferredSize
>
> test/jdk/javax/swing/JSplitPane/bug4749792.java line 53:
> 
>> 51:         JPanel right = new JPanel();
>> 52:         left.setSize(200, 200);
>> 53:         right.setSize(200, 200);
> 
> You may want to use preferred size for right and left panes so that the 
> JSplitPane divider is not skewed to the left.
>  
> Suggestion:
> 
>         left.setPreferredSize(new Dimension(200, 200));
>         right.setPreferredSize(new Dimension(200, 200));

Updated, thanks!

> test/jdk/javax/swing/JSplitPane/bug4749792.java line 58:
> 
>> 56: 
>> 57:         JPanel south = new JPanel();
>> 58:         south.setSize(new Dimension(20, 20));
> 
> Same with south and east panels - setPreferredSize()

Also updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24559#discussion_r2045322901
PR Review Comment: https://git.openjdk.org/jdk/pull/24559#discussion_r2045323290

Reply via email to