On Wed, 2 Apr 2025 17:34:34 GMT, Rajat Mahajan <rmaha...@openjdk.org> wrote:

> Details:
> Refactored code as requested in the Bug description.
> 
> Tested and verified the test passes.

LGTM apart from minor inline suggestion.

Since the test has lot of tab movements, does CI testing look good on all 
platforms on multiple runs (repeat) ?

test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java line 181:

> 179:         mainFrame.getContentPane()
> 180:                  .setLayout(new BoxLayout(mainFrame.getContentPane(),
> 181:                                           BoxLayout.Y_AXIS));

Minor nit:
Can be simplified by removing .getContentPane() from ln#170-173) as well 
similar to the following.

Suggestion:

        mainFrame.setLayout(new BoxLayout(mainFrame.getContentPane(),
                                          BoxLayout.Y_AXIS));

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24384#pullrequestreview-2769620853
PR Review Comment: https://git.openjdk.org/jdk/pull/24384#discussion_r2045355995

Reply via email to