On Tue, 15 Apr 2025 10:03:42 GMT, Tejesh R <t...@openjdk.org> wrote:

> Open source these AWT TextComponent tests:
> 
> java/awt/TextComponent/BackgroundTest/BackgroundTest.java
> java/awt/TextComponent/DisableTest/DisableTest.java
> java/awt/TextComponent/TextFieldMargin/TextFieldMargin.java
> java/awt/TextComponent/ModifiersTest/ModifiersTest.java

Tested all apps manually and they pass. One comment regarding numbering of 
steps.

test/jdk/java/awt/TextComponent/BackgroundTest.java line 57:

> 55:                    On linux and macos it will match the environment 
> settings.
> 56:                    If the TextField or the TextArea do not change colors 
> as described,
> 57:                    the test FAILS.

Suggestion:

                3. Press the "DisableText" button.
                   The first TextField and TextArea should change colors to the
                   default disabled color.  On Windows, this is usually gray.
                   On linux and macos it will match the environment settings.
                   If the TextField or the TextArea do not change colors as 
described,
                   the test FAILS.


The instructions jump from step #2 to #4 when I was following the test. The 
subsequent numbers need to be adjusted as well. Test itself passes locally for 
me though.

-------------

PR Review: https://git.openjdk.org/jdk/pull/24656#pullrequestreview-2770250791
PR Review Comment: https://git.openjdk.org/jdk/pull/24656#discussion_r2045754813

Reply via email to