On Tue, 15 Apr 2025 17:20:16 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Following tests are updates as part of this PR:
>>
>> 1. javax/swing/JRootPane/bug4614623.java - manual
>> 2. javax/swing/JTabbedPane/bug4613811.java - manual
>> 3. javax/swing/JWindow/bug4251781.java - manual
>> 4. javax/swing/JFrame/bug4419914.java - manual, updated existing test by
>> adding JWindow, JDialog cases.
>
> Harshitha Onkar has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - review update
> - review update
test/jdk/javax/swing/JRootPane/bug4614623.java line 49:
> 47: the "File" menu should now be underlined.
> 48: 2) Release the Alt key, the selection background (light grey)
> 49: should appear around the File menu. Compare "About" menu
Suggestion:
should appear around the "File" menu. Compare "About" menu
test/jdk/javax/swing/JRootPane/bug4614623.java line 59:
> 57:
> 58: PassFailJFrame.builder()
> 59: .title("Test Instructions")
Setting title is redundant. You can remove it and the default title would be
`Test File Name` + `Test Instructions`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24639#discussion_r2046194711
PR Review Comment: https://git.openjdk.org/jdk/pull/24639#discussion_r2046196782
