On Wed, 16 Apr 2025 04:39:22 GMT, Phil Race <p...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove incorrectly copied "§anchor"
>
> src/java.xml/share/legal/xhtml11.md line 50:
>
>> 48: or derived from [title and URI of the W3C document]."
>> 49:
>> 50: Disclaimers §anchor
>
> Did that come from an upstream file ?
No, it is copy/pasted from a textual rendering of the html file specified in
the URL above. This is what you get if you naïvely select the text in Firefox
and press Ctrl-C. The `§anchor` part is not rendered on screen.
> test/jdk/java/awt/geom/Path2D/GetBounds2DPrecisionTest.java line 193:
>
>> 191: if (str.length() >= DIGIT_COUNT) {
>> 192: str = str.substring(0,DIGIT_COUNT-1)+"...";
>> 193: }
>
> How did you test this ? Please say more than tiers 1-3 .. because this test
> isn't run until tier4.
I did not test tier4. Will do so now. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24567#discussion_r2046572753
PR Review Comment: https://git.openjdk.org/jdk/pull/24567#discussion_r2046573122
