On Wed, 16 Apr 2025 06:17:27 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:

>> Several multi screen related Applet tests are converted to manual and open 
>> sourced.
>
> Abhishek Kumar has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Remove unused variable

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/java/awt/Multiscreen/DialogTest.java line 101:

> 99:                 .columns(40)
> 100:                 .logArea(5)
> 101:                 .testUI(obj::init)

No need to create "obj"..we can call DialogTest.init directly..

test/jdk/java/awt/Multiscreen/IMCandidateWindowTest.java line 75:

> 73: 
> 74:         String INSTRUCTIONS = """
> 75:                 Platform: windows

this can be removed or rephrased "This test is for windows"

-------------

PR Review: https://git.openjdk.org/jdk/pull/24654#pullrequestreview-2772358999
PR Review Comment: https://git.openjdk.org/jdk/pull/24654#discussion_r2046834357
PR Review Comment: https://git.openjdk.org/jdk/pull/24654#discussion_r2046836826

Reply via email to