On Tue, 15 Apr 2025 14:29:20 GMT, Hendrik Schick <d...@openjdk.org> wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated review comments
>
> test/jdk/java/awt/ScrollPane/ScrollPaneComponentTest.java line 52:
>
>> 50: in the Frame titled 'ScrollPane Component Test'
>> 51: 2. Click the button labeled 'Remove and add back
>> 52: ScrollPane Contents
>
> Suggestion:
>
> ScrollPane Contents'
Updated.
> test/jdk/java/awt/ScrollPane/ScrollPaneSize.java line 97:
>
>> 95: add(b3 = new Button("Button3"));
>> 96:
>> 97: setBackground(Color.white);
>
> background color set twice?
Updated.
> test/jdk/java/awt/ScrollPane/ScrollPanechildViewportTest.java line 129:
>
>> 127: public Dimension getPreferredSize() {
>> 128: Dimension d = null;
>> 129: Dimension pd = ((ScrollPane) getParent()).getViewportSize();
>
> use switch expression (instead of switch statement) to assign a value to d?
Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24647#discussion_r2046952883
PR Review Comment: https://git.openjdk.org/jdk/pull/24647#discussion_r2046953107
PR Review Comment: https://git.openjdk.org/jdk/pull/24647#discussion_r2046953022
