On Wed, 16 Apr 2025 10:09:48 GMT, Alexander Zvegintsev <azveg...@openjdk.org>
wrote:
> Few more tests open sourced:
>
> javax/swing/JTextArea/4474400/bug4474400.java
> javax/swing/border/TitledBorder/TransparentTitleTest.java
> javax/swing/JComboBox/4139900/bug4139900.java
> javax/swing/JComboBox/4174876/bug4174876.java
test/jdk/javax/swing/JComboBox/bug4139900.java line 107:
> 105: };
> 106:
> 107: button.addActionListener( actionListener );
Suggestion:
button.addActionListener(actionListener);
test/jdk/javax/swing/JComboBox/bug4174876.java line 26:
> 24: /*
> 25: * @test
> 26: * @bug 4174876
Test summary is missing.
test/jdk/javax/swing/JComboBox/bug4474400.java line 59:
> 57:
> 58: private static JComponent createTestUI() {
> 59: JTextArea textArea;
Can be defined and initialised where its used.
test/jdk/javax/swing/border/TransparentTitleTest.java line 66:
> 64: JFrame frame = new JFrame("TransparentTitleTest");
> 65:
> 66: frame.setLayout(new GridLayout(3,6,5,5));
Suggestion:
frame.setLayout(new GridLayout(3, 6, 5, 5));
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24680#discussion_r2047036528
PR Review Comment: https://git.openjdk.org/jdk/pull/24680#discussion_r2047038295
PR Review Comment: https://git.openjdk.org/jdk/pull/24680#discussion_r2047043354
PR Review Comment: https://git.openjdk.org/jdk/pull/24680#discussion_r2047046646
