On Wed, 16 Apr 2025 20:37:19 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
> Following test are open-sourced in this PR: > > - javax/swing/DataTransfer/DragOverFeedbackTest.java - manual > - javax/swing/DataTransfer/ListDragOverFeedbackTest.java - manual > - javax/swing/DataTransfer/bug4655513.java - automated > - javax/swing/SwingUtilities/bug4369355.java - automated > - javax/swing/SwingUtilities/bug4967768.java - manual All tests (manual and automatic) pass and LGTM except maybe the `Oops` button test. I left a couple of comments. test/jdk/javax/swing/DataTransfer/ListDragOverFeedbackTest.java line 101: > 99: list2.setLayoutOrientation(JList.VERTICAL_WRAP); > 100: list2.setTransferHandler(handler); > 101: list2.setBorder(BorderFactory.createLineBorder(Color.BLACK)); The first two lists seem to be cut off on MacOS at least. The test itself works and passes. <img width="392" alt="Screenshot 2025-04-16 at 1 46 16 PM" src="https://github.com/user-attachments/assets/b452ed69-cc4a-4bb6-9cd1-c5ecce6bcec6"; /> test/jdk/javax/swing/SwingUtilities/bug4369355.java line 88: > 86: } > 87: } > 88: Extra newline at the EOF. test/jdk/javax/swing/SwingUtilities/bug4967768.java line 64: > 62: panel.add(but); > 63: return panel; > 64: } I don't see an underline under the `p` in `Oops` unless I'm misunderstanding the test. I'm on MacOS 15.4. <img width="439" alt="Screenshot 2025-04-16 at 1 50 55 PM" src="https://github.com/user-attachments/assets/af4d692f-8b38-47f5-b932-63487e23b722"; /> ------------- PR Review: https://git.openjdk.org/jdk/pull/24698#pullrequestreview-2773823817 PR Review Comment: https://git.openjdk.org/jdk/pull/24698#discussion_r2047746400 PR Review Comment: https://git.openjdk.org/jdk/pull/24698#discussion_r2047738055 PR Review Comment: https://git.openjdk.org/jdk/pull/24698#discussion_r2047741869
