On Wed, 9 Apr 2025 14:42:05 GMT, Maxim Kartashev <mkartas...@openjdk.org> wrote:

> The pixels that cairo produces for GTK LaF to draw on a Swing component have 
> their alpha components pre-multiplied as per [the 
> documentation](https://www.cairographics.org/manual/cairo-Image-Surfaces.html?spm=a2ty_o01.29997173.0.0.540ac921z2EebT#cairo-format-t):
>> Pre-multiplied alpha is used. (That is, 50% transparent red is 0x80800000, 
>> not 0x80ff0000.)
> 
> The BufferedImage created from those pixels, however, has its constructor's 
> argument for `isRasterPremultiplied` set to `false` in 
> `GTKEngine.finishPainting()`. This commit corrects that.
> 
> In addition, since at least some "native" graphics color models also use 
> pre-multiplied alpha (ex.: `GLXGraphicsConfig.getColorModel()`), 
> `COLOR_MODELS` were modified to take advantage of that and avoid unnecessary 
> re-calculations of image's pixels.

@mkartashev 
Your change (at version a5de12d505cfc2bddd3b13db4e39d0a4329f27bd) is now ready 
to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24551#issuecomment-2811951519

Reply via email to