On Thu, 17 Apr 2025 09:38:43 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> test/jdk/javax/swing/JFileChooser/HTMLFileName.java line 43:
>>
>>> 41: static File directory;
>>> 42: public static void main(String[] args) throws Exception {
>>> 43: String INSTRUCTIONS = """
>>
>> Why the windows is skipped?
>> Don't you need to check all L&F and platforms? as of now you validated
>> metal(default on linux) and aqua(default on mac).
>
>> Why the windows is skipped?
>
> Because it's impossible to create a file with `<html>` in the name on Windows.
>
>> Don't you need to check all L&F and platforms? as of now you validated
>> metal(default on linux) and aqua(default on mac).
>
> A good point. Validating other L&F would be good.
>
> I wonder if the test can be automated, it would make validating all L&F so
> much easier.
Making an automated test would be difficult, because the text/html is totally
OS and L&F dependant. Example without fix in macos the file name will be empty
on filepane and in combobox it shows as HTML text. But it doesn't hold the same
for other L&F and in linux.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24439#discussion_r2048697846
