On Thu, 17 Apr 2025 17:43:03 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> Open-sourcing and standardizing several swing tests (JTree)
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add headful tags
test/jdk/javax/swing/JTree/NodeChangedTest.java line 29:
> 27: * @summary Tests that node changed for the root of the tree update the
> 28: * structure.
> 29: * @key headful
Does it need to be headful? I see nothing is displayed so I asked you to check
in CI if it fails without headful tag..is it failing if we dont have headful?
test/jdk/javax/swing/JTree/bug4118860.java line 87:
> 85: tr.setToggleClickCount(2);
> 86: if (tr.getToggleClickCount() != 2) {
> 87: throw new Error("ToggleClickCount doesn't set...");
change all Error to RE
test/jdk/javax/swing/JTree/bug4169215.java line 28:
> 26: * @bug 4169215
> 27: * @summary Accessibility hierarchy JTree node test.
> 28: * @key headful
same here..nothing is displayed..so do we need headful tag?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24730#discussion_r2050034862
PR Review Comment: https://git.openjdk.org/jdk/pull/24730#discussion_r2050035867
PR Review Comment: https://git.openjdk.org/jdk/pull/24730#discussion_r2050037484
