On Fri, 18 Apr 2025 21:26:10 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> Clean up and open source some tests related to event processing in AWT
>> library.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update HWWheelScroll.java
>
> Set title on file dialog owner frame.
test/jdk/java/awt/event/MouseWheelEvent/HWWheelScroll.java line 114:
> 112: TextArea ta = new TextArea("", 0, 0, policy);
> 113: if (textShape == TEXT_TALL) {
> 114: for(int i = 0; i < 50 ; i++) {
Suggestion:
for (int i = 0; i < 50 ; i++) {
test/jdk/java/awt/event/MouseWheelEvent/HWWheelScroll.java line 124:
> 122: ta.append("text");
> 123: } else if (textShape == TEXT_BIG) {
> 124: for(int i = 0; i < 50 ; i++) {
Suggestion:
for (int i = 0; i < 50 ; i++) {
test/jdk/java/awt/event/MouseWheelEvent/HWWheelScroll.java line 134:
> 132: java.awt.List l = new java.awt.List();
> 133: if (textShape == TEXT_TALL) {
> 134: for(int i = 0; i < 50 ; i++) {
Suggestion:
for (int i = 0; i < 50 ; i++) {
test/jdk/java/awt/event/MouseWheelEvent/HWWheelScroll.java line 138:
> 136: }
> 137: } else if (textShape == TEXT_WIDE) {
> 138: for(int i = 0; i < 2 ; i++) {
Suggestion:
for (int i = 0; i < 2 ; i++) {
test/jdk/java/awt/event/MouseWheelEvent/HWWheelScroll.java line 144:
> 142: l.add("text");
> 143: } else if (textShape == TEXT_BIG) {
> 144: for(int i = 0; i < 50 ; i++) {
Suggestion:
for (int i = 0; i < 50 ; i++) {
test/jdk/java/awt/event/MouseWheelEvent/WheelEventCoord.java line 57:
> 55: public WheelEventCoord() {
> 56: super("Wheel Event Coordinates");
> 57: setLayout(new GridLayout(3,1));
Suggestion:
setLayout(new GridLayout(3, 1));
test/jdk/java/awt/event/MouseWheelEvent/WheelEventCoord.java line 85:
> 83:
> 84: public Dimension getPreferredSize() {
> 85: return new Dimension(300,100);
Suggestion:
return new Dimension(300, 100);
test/jdk/java/awt/event/MouseWheelEvent/WheelScrollEnabled.java line 98:
> 96:
> 97: add(pl2, BorderLayout.SOUTH);
> 98: setSize (400,200);
Suggestion:
setSize(400, 200);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24755#discussion_r2052085563
PR Review Comment: https://git.openjdk.org/jdk/pull/24755#discussion_r2052085713
PR Review Comment: https://git.openjdk.org/jdk/pull/24755#discussion_r2052085860
PR Review Comment: https://git.openjdk.org/jdk/pull/24755#discussion_r2052085968
PR Review Comment: https://git.openjdk.org/jdk/pull/24755#discussion_r2052086040
PR Review Comment: https://git.openjdk.org/jdk/pull/24755#discussion_r2052086484
PR Review Comment: https://git.openjdk.org/jdk/pull/24755#discussion_r2052086600
PR Review Comment: https://git.openjdk.org/jdk/pull/24755#discussion_r2052086774
