On Fri, 18 Apr 2025 18:08:36 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove redudant frame
>
> test/jdk/javax/swing/JFileChooser/bug4943900.java line 57:
>
>> 55: is updated properly.
>> 56:
>> 57: If the FileFilter works correctly, press PASS else press FAIL.
>
> I wonder why so many people use capitals for *Pass* and *Fail*…
Probably for emphasis
> test/jdk/javax/swing/JFileChooser/bug4943900.java line 100:
>
>> 98: }
>> 99:
>> 100: public String getExtension(File f) {
>
> Suggestion:
>
> private static String getExtension(File f) {
>
> This is an internal helper method for the class.
Updated
> test/jdk/javax/swing/JOptionPane/bug4194862.java line 57:
>
>> 55: .columns(40)
>> 56: .testUI(bug4194862::createAndShowUI)
>> 57: .build()
>
> Enable screenshot?
>
> I've been thinking about a feature which could the screenshot automatically…
> as a failure handler. There's a tracking bug for it,
> [JDK-8317114](https://bugs.openjdk.org/browse/JDK-8317114): *Provide failure
> handlers for PassFailJFrame*. Many UI manual tests could benefit from it,
Updated
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2052730784
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2052731298
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2052730597
