On Fri, 18 Apr 2025 22:28:56 GMT, Alisen Chung <[email protected]> wrote:
>> Updating and opening some tests
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix test
Changes requested by honkar (Reviewer).
test/jdk/javax/swing/JComboBox/bug4180054.java line 37:
> 35: * @test
> 36: * @bug 4180054
> 37: * @summary Tests that DefaultComboBoxModel doesn't fire a "contents
> changed" unneccesarily
Suggestion:
* @summary Tests that DefaultComboBoxModel doesn't fire a "contents changed"
unnecessarily
test/jdk/javax/swing/JComboBox/bug4530952.java line 51:
> 49: static volatile Point loc;
> 50:
> 51: private static boolean flag = false;
Can this be made volatile and directly be used in the test instead of using
passed() and pass(). These functions are not required if the var is directly
used in the test.
Suggestion:
private static boolean flag = false;
test/jdk/javax/swing/JComboBox/bug4530952.java line 140:
> 138:
> 139: public static void resetButtons() {
> 140: int length = ((JTextField)
> cmbAction.getEditor().getEditorComponent()).
Test fails since cmbAction is declared as local var in testUI ..probably change
it to static var if you need to access it in resetButtons?
test/jdk/javax/swing/JComboBox/bug4530953.java line 49:
> 47: SwingUtilities.invokeAndWait(() -> createTestUI());
> 48: robot.waitForIdle();
> 49: robot.delay(250);
Usually a delay of 1s is used after testUI creation.
Suggestion:
robot.delay(1000);
-------------
PR Review: https://git.openjdk.org/jdk/pull/24495#pullrequestreview-2781888363
PR Review Comment: https://git.openjdk.org/jdk/pull/24495#discussion_r2052782363
PR Review Comment: https://git.openjdk.org/jdk/pull/24495#discussion_r2052790364
PR Review Comment: https://git.openjdk.org/jdk/pull/24495#discussion_r2052790478
PR Review Comment: https://git.openjdk.org/jdk/pull/24495#discussion_r2052793420
