On Fri, 18 Apr 2025 22:40:14 GMT, Alisen Chung <ach...@openjdk.org> wrote:
>> Updating and opening some JComboBox bugs
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> move disposal onto edt
LGTM apart from minor suggestions
test/jdk/javax/swing/JComboBox/bug4212498.java line 34:
> 32: * @test
> 33: * @bug 4212498
> 34: * @key headful
`@key headful` not required for manual test
test/jdk/javax/swing/JComboBox/bug4459267.java line 49:
> 47:
> 48: SwingUtilities.invokeAndWait(() -> createTestUI());
> 49: robot.waitForIdle();
Suggestion:
robot.waitForIdle();
robot.delay(1000);
test/jdk/javax/swing/JComboBox/bug4519269.java line 56:
> 54:
> 55: SwingUtilities.invokeAndWait (() -> p =
> combo.getLocationOnScreen());
> 56: robot.mouseMove(p.x+5, p.y+5);
Suggestion:
robot.mouseMove(p.x + 5, p.y + 5);
-------------
Marked as reviewed by honkar (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24733#pullrequestreview-2782027288
PR Review Comment: https://git.openjdk.org/jdk/pull/24733#discussion_r2052869116
PR Review Comment: https://git.openjdk.org/jdk/pull/24733#discussion_r2052876327
PR Review Comment: https://git.openjdk.org/jdk/pull/24733#discussion_r2052881923
