On Mon, 21 Apr 2025 20:12:43 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update jtreg paths, volatile, manual jtreg tag > > test/jdk/javax/swing/JTable/bug4460382.java line 120: > >> 118: row1 = editingRow; >> 119: setValueAt(value, editingRow, editingColumn); >> 120: row2 = editingRow; > > Can you tell me what are we testing here? We extending JTable and we are > checking that during the cell content replacement some random internal > protected variable does not change. What does it tells us? Why is it a > criteria of test passing or not? i think this test should probably be removed, since the manual test was also like this in that it didn't really test anything. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24735#discussion_r2053098563