On Mon, 21 Apr 2025 22:58:37 GMT, Alisen Chung <ach...@openjdk.org> wrote:

>> Updating and opening some tests
>
> Alisen Chung has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   reduce number of rows

LGTM, minor suggestions added.

test/jdk/javax/swing/JComboBox/bug4201964.java line 55:

> 53:         PassFailJFrame.builder()
> 54:                 .instructions(INSTRUCTIONS)
> 55:                 .rows(30)

.rows(8) ?

test/jdk/javax/swing/JComboBox/bug4249732.java line 61:

> 59:                 .build()
> 60:                 .awaitAndCheck();
> 61:     }

The Instruction window has a lot of white space. May be consider decreasing 
number of rows to 8 ?
<img width="250" alt="image" 
src="https://github.com/user-attachments/assets/6722bdc2-0469-4af3-a340-50f87552ad24";
 />

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24496#pullrequestreview-2782723918
PR Review Comment: https://git.openjdk.org/jdk/pull/24496#discussion_r2053307657
PR Review Comment: https://git.openjdk.org/jdk/pull/24496#discussion_r2053310369

Reply via email to