On Tue, 22 Apr 2025 11:58:51 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:

>> Now that CI linux system is transitioned, the 
>> [JDK-8346828](https://bugs.openjdk.org/browse/JDK-8346828) changes is 
>> reverted and test is made headful and run on all platforms including macos.
>> CI testing is ok now..
>
> test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java line 1:
> 
>> 1: /*
> 
> If the test is restored to it's previous version, is it correct to restore 
> copyright year also ?

Few unneeded changes like setDefaultCLoseOperation were not taken in and 
there's no need of additional delay..so copyright year change is needed

> test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java line 35:
> 
>> 33: import java.awt.event.MouseAdapter;
>> 34: import java.awt.event.MouseEvent;
>> 35: import java.awt.Robot;
> 
> Suggestion:
> 
> import java.awt.Dimension;
> import java.awt.Robot;
> import java.awt.event.MouseAdapter;
> import java.awt.event.MouseEvent;

I guess my sorting is right..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24774#discussion_r2054017488
PR Review Comment: https://git.openjdk.org/jdk/pull/24774#discussion_r2054019818

Reply via email to