On Tue, 22 Apr 2025 23:05:01 GMT, Alexander Zvegintsev <azveg...@openjdk.org>
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add delay at the start of runTest. Modify final reminder.
>
> test/jdk/javax/swing/JScrollPane/AcceleratedWheelScrolling/HorizScrollers.java
> line 166:
>
>> 164: ("Test %s. Please make sure you have set " +
>> 165: "the correct speed value and keep the "
>> +
>> 166: "mouse stationary.")
>
> The updated instructions should be corrected as well.
>
> It seems that this `JOptionPane` dialog is only displayed when one of the
> phases fails at non-default speed, and there is no further testing.
> So the the `keep the mouse stationary` part is a little bit too late.
>
> This can be an issue though, but I think it is better to add a delay just
> before the test starts(`RTLScrollers.runTest`) to avoid catching mouse
> movements from a test used when he clicks the button.
I see your point. Adjusted the dialog again to make sense for both pass/fail to
restore the original speed.
Also added a `robot.delay` to the beginning of `runTest`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24804#discussion_r2055025696
