> This removes the constant repainting of the AquaRootPaneUI's default button.
>
> A long time ago (before Mac OS Yosemite, around 2014) this was needed to
> match Aqua's native experience. But the default button no longer pulses, so
> we don't need to repaint ("pulse") the button continually.
>
> Here's a clip from a YouTube video I found demonstrating the pulsing effect
> that this PR removes (you may want to turn your volume off):
>
> https://github.com/user-attachments/assets/496bc003-ccba-4178-81bc-765e96d94316
>
> This PR includes a test, but this test has never failed. (That is: this PR
> does not resolve a failing test.) This test would fail if the default button
> ever looked the same as a non-default button.
>
> My primary goal here was to remove the AquaButtonUI's AncestorListener, but
> while we're here we might as well remove the AquaRootPaneUI's timer and other
> cleanup.
>
> I tried and failed to rename the `private static final byte _pulsed`
> constant. (More details
> [here](https://github.com/openjdk/jdk/commit/89d0689f226b9e883df464e6f3e8c20074970499).)
> If anyone has suggestions for how to rename that without errors please let
> me know.
Jeremy Wood has updated the pull request incrementally with two additional
commits since the last revision:
- 8355203: breaking up long line into multiple lines
This is in response to:
https://github.com/openjdk/jdk/pull/24778#discussion_r2059701077
- 8355203: breaking up long line into multiple lines
This is in response to:
https://github.com/openjdk/jdk/pull/24778#discussion_r2059701077
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24778/files
- new: https://git.openjdk.org/jdk/pull/24778/files/60021fcc..562804e5
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24778&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24778&range=01-02
Stats: 37 lines in 1 file changed: 15 ins; 0 del; 22 mod
Patch: https://git.openjdk.org/jdk/pull/24778.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24778/head:pull/24778
PR: https://git.openjdk.org/jdk/pull/24778
