On Tue, 29 Apr 2025 14:15:40 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>>> I'm sure this problem was discussed somewhere… (I'll search for that >>> discussion later.) We should limit testing to default configurations only. >> >> It was in #21942, its description reads >> >>> I think the large number of XVisuals may have something to do with it.\ >>> I've updated it quite a bit and limited the number of dialogs it creates - >>> we really don't need to test 300 of them >> >> The updated code reduces the number of tested graphics configurations to 10: >> >> https://github.com/openjdk/jdk/blob/edf8ce8db10521037045115f4cb9569a1477a40a/test/jdk/java/awt/Graphics2D/ScaledTransform/ScaledTransform.java#L58-L62 > >> #21942 > > Thanks @aivanov-jdk for suggesting the correct route. > > @kboulanou Please modify the test to run for all platforms and you can limit > the number of graphics configuration to 10 for linux. > @kumarabhi006 I am aware that I should not force push to PR. But, I made the > mistake of pushing updates (sync) from master to this PR so it added 200 > commits to this PR, which will make the PR confusing. I should have updated > master and fork and rebased my branch on it and then push to PR. I will be > more careful in the future. Please suggest if this is OK. Thanks. @kboulanou Merging master is safe. **Don't use `git rebase`**, though. Never use `git rebase` after you published your branch for PR. If you merge (sync) changes from master, Git won't show them as differences. The PR compares your branch to master. By merging, you add more commits that already exist in master, which means no changes between master and your branch are added. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24752#issuecomment-2842733768
