> Unfortunately I'm unable to reproduce this failure. I slowed the test down; > it passes on my machine before and after this PR. > > I added a little bit of logging that might also help identify what's > happening. > > Does anyone have any more suggestions?
Jeremy Wood has updated the pull request incrementally with two additional commits since the last revision: - 8356061: restructuring to move things to EDT This was requested here: https://github.com/openjdk/jdk/pull/25244#discussion_r2091656355 mrserb asked: "Also please move creation and access_to all Swing components to EDT" (I'm not sure this will help much? My understanding was *creation* of Swing components could happen off the EDT as long as they were made displayable on the EDT.) Now we still call jc.getLocationOnScreen off the EDT. If that posed a thread-based problem it'd probably manifest as a IllegalComponentStateException, which is not mentioned in 8356061. - 8356061: adding 1000ms pause after window construction This was requested here: https://github.com/openjdk/jdk/pull/25244#discussion_r2091656355 So now we'll pause at least 1.1s before the first call to `jc.getLocationOnScreen`, and at least 2.1s before the first call to `robot.getPixelColor(x, y)`. (getLocationOnScreen has never failed with an IllegalStateException.) ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25244/files - new: https://git.openjdk.org/jdk/pull/25244/files/b7270924..b076c964 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25244&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25244&range=00-01 Stats: 183 lines in 1 file changed: 92 ins; 77 del; 14 mod Patch: https://git.openjdk.org/jdk/pull/25244.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25244/head:pull/25244 PR: https://git.openjdk.org/jdk/pull/25244
