On Mon, 19 May 2025 12:16:57 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains three commits: >> >> - File merge >> - Review comment fix, latch and other changes >> - Test Stabilization > > test/jdk/java/awt/List/ListEnterExitTest.java line 1: > >> 1: /* > > I strongly suggest making `MouseEnterExitListener` a static nested class > inside `ListEnterExitTest`. This prevents any duplicate class names from > other classes when one works with tests in an IDE. Updated. > test/jdk/java/awt/List/ListEnterExitTest.java line 92: > >> 90: >> 91: robot.mousePress(InputEvent.BUTTON1_MASK); >> 92: robot.mouseRelease(InputEvent.BUTTON1_MASK); > > Is this mouse press needed only to release `mouseEnterExitListener.wait`? > > I suggest using a `CountDownLatch` to replace > `MouseEnterExitListener.passed_1` and `passed_2`. The code would need to > time-await for both latches to be released. > > Then `MouseEnterExitListener.mousePressed` can be removed completely together > with the synchronized block above. Updated with CountDownlatch to track mouse enter and exit events. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25299#discussion_r2097240158 PR Review Comment: https://git.openjdk.org/jdk/pull/25299#discussion_r2097239878
