On Wed, 21 May 2025 04:36:38 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> Test was failing on macOS 14.7.1 system in CI pipeline. Logged output
>> suggests that the mouse exit event is not triggered and thus the test fails.
>> Increased number of list items and adjusted the X and Y offset for mouse
>> move events, so the mouse pointer will be within the frame and added robot
>> delay to stabilize the test.
>>
>> Verified the updated test in CI on macOS 14.7 machine and there is no
>> failure.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment fix
Looks good to me except for a few nits.
test/jdk/java/awt/List/ListEnterExitTest.java line 49:
> 47: Frame frame;
> 48: volatile Point p;
> 49: private static final int X_OFFSET = 30;
Suggestion:
volatile Point p;
private static final int X_OFFSET = 30;
I'd add a blank line between these two blocks.
test/jdk/java/awt/List/ListEnterExitTest.java line 113:
> 111:
> 112: private class MouseEnterExitListener extends MouseAdapter {
> 113: public void mouseEntered(MouseEvent e) {
Suggestion:
private class MouseEnterExitListener extends MouseAdapter {
@Override
public void mouseEntered(MouseEvent e) {
test/jdk/java/awt/List/ListEnterExitTest.java line 118:
> 116: }
> 117:
> 118: public void mouseExited(MouseEvent e) {
Suggestion:
@Override
public void mouseExited(MouseEvent e) {
-------------
Marked as reviewed by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25299#pullrequestreview-2857464612
PR Review Comment: https://git.openjdk.org/jdk/pull/25299#discussion_r2100129084
PR Review Comment: https://git.openjdk.org/jdk/pull/25299#discussion_r2100125431
PR Review Comment: https://git.openjdk.org/jdk/pull/25299#discussion_r2100127395
