On Wed, 21 May 2025 17:06:00 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Small unification of "header size" constants, as of now the CMM code uses: >> 1. sun.java2d.cmm.ProfileDataVerifier.HEADER_SIZE introduced in JDK-8013430 >> 2. java.awt.color.ICC_Profile.HEADER_SIZE introduced in >> [JDK-8347377](https://bugs.openjdk.org/browse/JDK-8347377) >> 3. Hardcoded literal 128 > > src/java.desktop/share/classes/sun/java2d/cmm/ProfileDataVerifier.java line > 111: > >> 109: public static final int HEADER_SIZE = 128; >> 110: private static final int TOC_OFFSET = HEADER_SIZE + 4; >> 111: private static final int TOC_RECORD_SIZE = 12; > > Minor: All the constants are defined at the end of file, is it better to move > them to the beginning ? Perhaps someday when we go for this kind of unification ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25313#discussion_r2101096420
