On Thu, 29 May 2025 21:55:41 GMT, Phil Race <p...@openjdk.org> wrote:
>> Daniel Gredler has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove one last now-unnecessary whitespace check inside CMap
>
> src/java.desktop/share/classes/sun/print/RasterPrinterJob.java line 2485:
>
>> 2483: for (int i = 0; i < len; i++) {
>> 2484: char c = in_chars[i];
>> 2485: if (c > '\r' || c < '\t' || c == '\u000b' || c ==
>> '\u000c') {
>
> hmm. looks like you are fixing a bug here. I think those == were supposed to
> be !=
Hah, I've had to check it a few times but I do think the code was correct --
just formulated in a confusing way, probably as a micro-optimization.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24412#discussion_r2114953676
