On Fri, 6 Jun 2025 07:37:54 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Jeremy Wood has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8354646: update SetEchoCharWordOpsTest to refer to 8354646 >> >> This is in response to: >> https://github.com/openjdk/jdk/pull/25443#discussion_r2131645722 > > test/jdk/javax/swing/plaf/basic/BasicPasswordFieldUI/PasswordSelectionWordTest.java > line 64: > >> 62: e.printStackTrace(); >> 63: return false; >> 64: } catch (RuntimeException e) { > > guess this catch block is not needed OK; this is updated > test/jdk/javax/swing/plaf/basic/BasicPasswordFieldUI/PasswordSelectionWordTest.java > line 94: > >> 92: if (selectionStart != 0 || selectionEnd != str.length()) { >> 93: throw new Error("selectionStart = " + selectionStart + >> 94: " and selectionEnd = " + selectionEnd); > > please change to RuntimeException to make it consistent with other tests OK; this is updated ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25443#discussion_r2131716706 PR Review Comment: https://git.openjdk.org/jdk/pull/25443#discussion_r2131716615
