On Tue, 10 Jun 2025 20:50:07 GMT, Alisen Chung <ach...@openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8359053
>
> src/java.desktop/share/classes/java/awt/Polygon.java line 163:
>
>> 161: throw new NegativeArraySizeException("npoints < 0");
>> 162: }
>> 163: // Fix 6343431: compatibility problems if arrays are not
>
> should this comment just be removed entirely?
The bug wasn't specific to applets.
> src/java.desktop/share/classes/java/awt/Toolkit.java line 1353:
>
>> 1351:
>> 1352: /**
>> 1353: * {@return the {@code EventQueue} for this application}
>
> why is this specification in brackets?
It's a nice feature I only learned about recently.
It generates a comment as well as an @return line.
> src/java.desktop/share/classes/javax/swing/JComponent.java line 108:
>
>> 106: * whose root is a top-level Swing container.
>> 107: * Top-level Swing containers --
>> 108: * such as <code>JFrame</code>, <code>JDialog</code> --
>
> "and" instead of comma maybe?
oh yes
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25698#discussion_r2138781413
PR Review Comment: https://git.openjdk.org/jdk/pull/25698#discussion_r2138782561
PR Review Comment: https://git.openjdk.org/jdk/pull/25698#discussion_r2138784961
