On Tue, 10 Jun 2025 23:51:09 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> Anass Baya has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove global lock > > src/java.desktop/windows/native/libawt/windows/awt_Window.cpp line 2507: > >> 2505: // before our java peer - if we're dispose()d, for instance. >> 2506: // Return the default screen. >> 2507: JNI_CHECK_PEER_GOTO(self, ret); > > I suggest reordering it slightly - this pattern is commonly used in most > cases where JNI_CHECK_PEER_GOTO is used: > > result...; > AwtWindow *window = NULL; > > PDATA pData; > JNI_CHECK_PEER_GOTO(self, ret); > window = (AwtWindow *)pData; I still suggest this order. Also, please add the new bug ID to the GetGraphicsStressTest. btw I'm still looking into the new test - it always passes for me. Can we tweak it to reproduce the bug more reliably? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25619#discussion_r2139042941
