On Mon, 16 Jun 2025 15:24:47 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> When trying to call 'icon.setImage(null);' where 'icon' is an instance of
>> ImageIcon, a null pointer exception is thrown at runtime.
>> The code tried to get the `id` for that image and instantiates
>> `MediaTracker` to associate the null image to that `id` and checks the
>> status of loading this null image, removes the null image from the tracker
>> and then tries to get the image width where it throws NPE as image is null.
>>
>> It's better to not go through all MediaTracker usage and bail out initially
>> itself for null image..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix
test/jdk/javax/swing/ImageIcon/ImageIconNullImageTest.java line 38:
> 36: public static void main(String[] args) throws Exception {
> 37: testImageIconNULL();
> 38: testSetImageNULL();
I particularly don't like the upper-case for `null`, in my opinion, `-Null` is
better and aligns with Java naming conventions.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25767#discussion_r2150294198
