On Wed, 18 Jun 2025 05:45:53 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added SkippedException when Printer is unavailable.
>
> test/jdk/java/awt/print/Dialog/DialogType.java line 53:
>
>> 51: The test passes as long as no exceptions are thrown, *AND*
>> 52: if running on Windows only, the first dialog is a native windows
>> 53: control which differs in appearance from the second dialog
>
> Suggestion:
>
> The test passes as long as no exceptions are thrown.
>
> Platform specific instructions can be added as a NOTE. It would be better if
> it is mentioned at the start of instruction.
>
> The first and second dialog differs on MacOS as well. Not checked on Linux.
>
> Current instruction says only about Windows, better to verify and modify the
> instruction.
Reconfirmed by testing on Mac OS and Linux as well - both of these have
different dialogs for first and second.
As suggested, added a note. But I have added it at the end as it seemed to be
better to first step through the instructions and then give an OS specific
context for those instructions.
> test/jdk/java/awt/print/Dialog/DialogType.java line 62:
>
>> 60: }
>> 61: PassFailJFrame passFailJFrame = PassFailJFrame.builder()
>> 62: .title("DialogType Test Instructions")
>
> Default title is : "File name" followed by " - Test Instructions"
> Title can be removed.
Removed.
> test/jdk/java/awt/print/Dialog/DialogType.java line 64:
>
>> 62: .title("DialogType Test Instructions")
>> 63: .instructions(INSTRUCTIONS)
>> 64: .rows((int)INSTRUCTIONS.lines().count() + 2)
>
> No need to set `rows` explicitly.
Removed.
> test/jdk/java/awt/print/Dialog/DialogType.java line 84:
>
>> 82: for (int i = 0; i < attrs.length; i++) {
>> 83: System.out.println(attrs[i]);
>> 84: }
>
> Move the duplicate code to helper method
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2156486862
PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2156487908
PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2156487570
PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2156488310
