On Fri, 20 Jun 2025 05:09:10 GMT, Srinivas Mandalika <smandal...@openjdk.org>
wrote:
>> Use PassFailJFrame to streamline the test
>> java/awt/print/Dialog/DialogType.java, as is for several of the manual tests.
>>
>> Modified Manual Test Passed when run using jtreg.
>
> Srinivas Mandalika has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fixed a type in the instructions.
>
> Co-authored-by: Alexey Ivanov <alexey.iva...@oracle.com>
Changes requested by aivanov (Reviewer).
test/jdk/java/awt/print/Dialog/DialogType.java line 47:
> 45:
> 46: private static final String INSTRUCTIONS = """
> 47: This test assumes and requires that you have a printer installed.
The test will not start if there's no printer now, so the first sentence can be
safely removed from the instructions.
test/jdk/java/awt/print/Dialog/DialogType.java line 51:
> 49: to optionally select a native dialog where one is present.
> 50: Two dialogs are shown in succession.
> 51: The test passes as long as no exceptions are thrown.
In fact, the instructions could be improved too.
Suggestion:
Two print dialogs are shown in succession.
Click Cancel in the dialogs to close them.
On macOS & on Windows, the first dialog is a native
dialog provided by the OS, the second dialog is
implemented in Swing, the dialog differ in appearance.
The test passes as long as no exceptions are thrown.
(If there's an exception, the test will fail automatically.)
The test verifies that the dialogs behave properly when using new API
to optionally select a native dialog where one is present.
test/jdk/java/awt/print/Dialog/DialogType.java line 53:
> 51: The test passes as long as no exceptions are thrown.
> 52: Note: On macOS & on Windows, the first dialog is a native
> 53: control which differs in appearance from the second dialog
Suggestion:
The test passes as long as no exceptions are thrown.
Note: On macOS & on Windows, the first dialog is a native
control which differs in appearance from the second dialog.
I agree with Abhishek suggestion, a blank here would make the instructions
easier to parse.
End the last sentence with a full stop, too.
-------------
PR Review: https://git.openjdk.org/jdk/pull/25842#pullrequestreview-2945899214
PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2158830452
PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2158847752
PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2158832386
