On Mon, 23 Jun 2025 23:05:54 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> Anass Baya has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Enhance the test
>
> test/jdk/java/awt/Frame/NotifyStressTest/NotifyStressTest.java line 57:
>
>> 55: for (int i = 0; i < 10; i++) {
>> 56: f.removeNotify();
>> 57: f.addNotify();
>
> Note that we call addNotify last, so the frame will not be disposed at the
> end of the test.
> btw, I cannot reproduce the bug even with the updated test. If you look at
> the stack trace, it seems the error comes from displayChanged, which is not
> triggered by the test itself
you can use this test:
/*
* Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
import java.awt.Window;
/**
* @test
* @bug 8346952
* @key headful
*/
public final class BogusFocusableWindowState {
public static void main(String[] args) {
Window frame = new Window(null) {
@Override
public boolean getFocusableWindowState() {
removeNotify();
return true;
}
};
try {
frame.pack();
frame.setVisible(true);
} finally {
frame.dispose();
}
}
}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25619#discussion_r2162667111
